Add additional validation for CONF_ENTRY_MAX_VOLUME value in the setup process to be greater than zero (#24)

Fixes #19
This commit is contained in:
Samuel Spagl 2024-04-01 10:49:48 +02:00 committed by GitHub
parent 3bcabb8c77
commit 430f6a1840
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 11 additions and 2 deletions

View File

@ -1,5 +1,13 @@
# Changelog # Changelog
## [0.3.2] Fix division by zero
### Added
- The config flow now also checks whether the `int` provided for `CONF_ENTRY_MAX_VOLUME` is
greater than `1` and lower than `100`. This will make sure that a division by zero cannot happen.
- Add default value `100` to `CONF_ENTRY_MAX_VOLUME`
## [0.3.1] Documentation enhancements ## [0.3.1] Documentation enhancements
### Changed ### Changed

View File

@ -5,6 +5,7 @@ import voluptuous as vol
from homeassistant import config_entries from homeassistant import config_entries
from homeassistant.helpers.aiohttp_client import async_get_clientsession from homeassistant.helpers.aiohttp_client import async_get_clientsession
from pysmartthings import APIResponseError from pysmartthings import APIResponseError
from voluptuous import All, Range
from .const import (CONF_ENTRY_API_KEY, CONF_ENTRY_DEVICE_ID, from .const import (CONF_ENTRY_API_KEY, CONF_ENTRY_DEVICE_ID,
CONF_ENTRY_DEVICE_NAME, CONF_ENTRY_MAX_VOLUME, DOMAIN) CONF_ENTRY_DEVICE_NAME, CONF_ENTRY_MAX_VOLUME, DOMAIN)
@ -45,7 +46,7 @@ class ExampleConfigFlow(config_entries.ConfigFlow, domain=DOMAIN):
vol.Required(CONF_ENTRY_API_KEY): str, vol.Required(CONF_ENTRY_API_KEY): str,
vol.Required(CONF_ENTRY_DEVICE_ID): str, vol.Required(CONF_ENTRY_DEVICE_ID): str,
vol.Required(CONF_ENTRY_DEVICE_NAME): str, vol.Required(CONF_ENTRY_DEVICE_NAME): str,
vol.Required(CONF_ENTRY_MAX_VOLUME): int, vol.Required(CONF_ENTRY_MAX_VOLUME, default=100): All(int, Range(min=1, max=100))
} }
), ),
) )

View File

@ -8,5 +8,5 @@
"iot_class": "cloud_polling", "iot_class": "cloud_polling",
"issue_tracker": "https://github.com/samuelspagl/ha_samsung_soundbar/issues", "issue_tracker": "https://github.com/samuelspagl/ha_samsung_soundbar/issues",
"requirements": ["pysmartthings"], "requirements": ["pysmartthings"],
"version": "0.3.1" "version": "0.3.2"
} }